[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080908140824.5ab3c7ca@extreme>
Date: Mon, 8 Sep 2008 14:08:24 -0700
From: Stephen Hemminger <shemminger@...tta.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: jbarnes@...tuousgeek.org, bhutchings@...arflare.com,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] PCI: vpd handle longer delays in access
On Mon, 8 Sep 2008 13:40:25 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Thu, 04 Sep 2008 13:56:37 -0700
> Stephen Hemminger <shemminger@...tta.com> wrote:
>
> > Accessing the VPD area can take a long time. The existing
> > VPD access code fails consistently on my hardware. There are comments
> > in the SysKonnect vendor driver that it can take up to 13ms per word.
> >
> > Change the access routines to:
> > * use a mutex rather than spinning with IRQ's disabled and lock held
> > * have a longer timeout
> > * call schedule while spinning to provide some responsivness
>
> It doesn't call schedule() - it calls yield().
>
> yield() is pretty notoriously badly behaved in the presence of lots of
> runnable tasks and there's been a general move to eradicate its
> in-kernel callsites.
>
> An alternative would be nice.
What is a good way to say "i am polling for a while"?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists