linux-kernel - Re: [PATCH] rate limit drm:radeon_cp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2008 01:12:11 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Roberto Oppedisano <roppedisano@...racomspa.it>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	dri-devel@...ts.sourceforge.net, Dave Airlie <airlied@...ux.ie>
Subject: Re: [PATCH] rate limit drm:radeon_cp_idle/reset errors

On Tue, 9 Sep 2008 09:37:32 +0200 Roberto Oppedisano <roppedisano@...racomspa.it> wrote:

> On Mon, Sep 08, 2008 at 09:08:36PM -0700, Andrew Morton wrote:
> > On Sat, 6 Sep 2008 11:19:19 +0200 Roberto Oppedisano <roppedisano@...racomspa.it> wrote:
> > 
> > > When switching from kwin composite wm (KDE 4.1) to compiz I often hit the
> > > following error:
> > > 
> > > Sep  6 10:24:31 poppero1 kernel: [  186.138203] [drm:radeon_cp_idle] *ERROR* radeon_cp_idle called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:31 poppero1 kernel: [  186.138568] [drm:radeon_cp_reset] *ERROR* radeon_cp_reset called without lock held, held  0 owner f726bc80 f68f6840
> > > 
> > > probably due to broken X drivers/apps; after hitting this the error my laptop
> > > (hp nx7010) is totally unresponsitive to keyboard/mouse, also if it can be 
> > > shut down via the power button:
> > > 
> > > Sep  6 10:24:59 poppero1 powersave-wm_shutdown[4843]: DIAG: Process script for event button.power ID 10
> > > Sep  6 10:24:59 poppero1 powersave-wm_shutdown[4843]: INFO: Event: BUTTON_POWER occured.
> > > Sep  6 10:24:59 poppero1 powersave-wm_shutdown[4843]: INFO: Parameters: Event - button.power; Current Active Scheme: scheme_performance - ACPI event line: button/power PWRF 00000080
> > > 00000001
> > > Sep  6 10:25:00 poppero1 shutdown[4852]: shutting down for system halt
> > > ...
> > > 
> > > Without the attached patch, which rate limits DRM_ERROR, the syslog is flooded
> > > by thuosands of messages; here's the output with the patch applied.
> > > 
> > > Sep  6 10:24:31 poppero1 kernel: [  186.138774] [drm:radeon_cp_start] *ERROR* radeon_cp_start called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:31 poppero1 kernel: [  186.138968] [drm:radeon_cp_idle] *ERROR* radeon_cp_idle called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:31 poppero1 kernel: [  186.139214] [drm:radeon_cp_reset] *ERROR* radeon_cp_reset called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:31 poppero1 kernel: [  186.139408] [drm:radeon_cp_start] *ERROR* radeon_cp_start called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:31 poppero1 kernel: [  186.139601] [drm:radeon_cp_idle] *ERROR* radeon_cp_idle called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:31 poppero1 kernel: [  186.139866] [drm:radeon_cp_reset] *ERROR* radeon_cp_reset called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:31 poppero1 kernel: [  186.140072] [drm:radeon_cp_start] *ERROR* radeon_cp_start called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:31 poppero1 kernel: [  186.140467] [drm:radeon_cp_idle] *ERROR* radeon_cp_idle called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:36 poppero1 kernel: [  191.139019] __ratelimit: 253431 callbacks suppressed
> > > Sep  6 10:24:36 poppero1 kernel: [  191.139030] [drm:radeon_cp_reset] *ERROR* radeon_cp_reset called without lock held, held  0 owner f726bc80 f68f6840
> > > Sep  6 10:24:36 poppero1 kernel: [  191.139314] [drm:radeon_cp_start] *ERROR* radeon_cp_start called without lock held, held  0 owner f726bc80 f68f6840
> > > 
> > > Also if it doesn't solve a bug I think it may still be worth applying it. 
> > > Patch is against current git.
> > > 
> > > Signed-off-by: Roberto Oppedisano <roberto.oppedisano@...racom.it>
> > > 
> > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> > > index 1c1b13e..1107361 100644
> > > --- a/include/drm/drmP.h
> > > +++ b/include/drm/drmP.h
> > > @@ -162,7 +162,8 @@ struct drm_device;
> > >   * \param arg arguments
> > >   */
> > >  #define DRM_ERROR(fmt, arg...) \
> > > -	printk(KERN_ERR "[" DRM_NAME ":%s] *ERROR* " fmt , __func__ , ##arg)
> > > +	if (printk_ratelimit()) \
> > > +		printk(KERN_ERR "[" DRM_NAME ":%s] *ERROR* " fmt , __func__ , ##arg)
> > >  
> > >  /**
> > >   * Memory error output.
> > > 
> > 
> > Which kernel version(s)?
> 
> This is against vanilla current git. 
> 
> Linux poppero1 2.6.27-rc5-00000-g7686ad5-dirty #1 PREEMPT Sun Sep 7 08:47:08 CEST 2008 i686 GNU/Linux
> 

Thanks.  I should have asked earlier: was 2.6.26 OK?  Any other kernels
tested?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/