[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 9 Sep 2008 06:05:14 -0600
From: Matthew Wilcox <matthew@....cx>
To: Alex Chiang <achiang@...com>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
jbarnes@...tuousgeek.org, kristen.c.accardi@...el.com,
kaneshige.kenji@...fujitsu.com
Subject: Re: [PATCH v2 01/13] PCI Hotplug core: add 'name' param pci_hp_register interface
On Tue, Sep 09, 2008 at 04:00:07AM -0600, Alex Chiang wrote:
> -extern int pci_hp_register(struct hotplug_slot *, struct pci_bus *, int nr);
> +extern int pci_hp_register(struct hotplug_slot *,
> + struct pci_bus *,
> + int nr,
> + const char *name);
Not a huge fan of this style ... the usual style would be:
extern int pci_hp_register(struct hotplug_slot *, struct pci_bus *, int nr,
const char *name);
Otherwise Acked-by: Matthew Wilcox <willy@...ux.intel.com>
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists