linux-kernel - Re: [PATCH 01/18] lirc core device driver infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2008 15:10:26 +0200
From:	Janne Grunau <j@...nau.net>
To:	Sebastian Siewior <lkml@...breakpoint.cc>
Cc:	Jarod Wilson <jwilson@...hat.com>, linux-kernel@...r.kernel.org,
	Jarod Wilson <jarod@...hat.com>,
	Christoph Bartelmus <lirc@...telmus.de>,
	Mario Limonciello <superm1@...ntu.com>
Subject: Re: [PATCH 01/18] lirc core device driver infrastructure

On Tuesday 09 September 2008 14:33:35 Sebastian Siewior wrote:
> * Janne Grunau | 2008-09-09 11:53:48 [+0200]:
> >> >+
> >> >+	bytes_in_key = p->code_length/8 + (p->code_length%8 ? 1 : 0);
> >>
> >> did you actually pass checkpatch.pl ?
> >
> >yes, and while this is ugly I see no obvious CodingStyle violation.
> >
> >is following better?
> >
> >bytes_in_key = p->code_length/8;
> >if (p->code_length%8)
> >	bytes_in_key++;
>
> bytes_in_key = p->code_length / 8;
> if (p->code_length % 8)
> 	bytes_in_key++;
>
> I meant the missing spaces around / and %. Looking now at it, it
> seems that it behaves like DIV_ROUND_UP(). The magic of spaces :)

There is also BITS_TO_LONGS(x) which does the intended. I found it only 
since it uses DIV_ROUND_UP. Will use that. Thanks.

Janne
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/