linux-kernel - [PATCH] ti_usb_3410_5052 obviously broken by firmware changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 8 Sep 2008 21:20:00 -0500
From:	Chris Adams <cmadams@...aay.net>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] ti_usb_3410_5052 obviously broken by firmware changes

From: Chris Adams <cmadams@...aay.net>

While making some other changes to ti_usb_3410_5052, I noticed that the
changes made to move the firmware loading to a separate function are
broken (in ti_download_firmware(), status is set to -ENOMEM and never
changed).  This means the driver will never initialize the device
properly.  It looks like status was supposed to get the result of
ti_do_download().

Signed-off-by: Chris Adams <cmadams@...aay.net>
---
It doesn't look like there's a maintainer for this driver other than TI
(which has no email listed).  Should changes for this go to linux-usb,
here, or what?


diff -urpN linux-2.6.27-rc5-git9-vanilla/drivers/usb/serial/ti_usb_3410_5052.c linux-2.6.27-rc5-git9/drivers/usb/serial/ti_usb_3410_5052.c
--- linux-2.6.27-rc5-git9-vanilla/drivers/usb/serial/ti_usb_3410_5052.c	2008-09-08 20:57:56.000000000 -0500
+++ linux-2.6.27-rc5-git9/drivers/usb/serial/ti_usb_3410_5052.c	2008-09-08 21:02:13.000000000 -0500
@@ -1744,7 +1744,7 @@ static int ti_download_firmware(struct t
 	if (buffer) {
 		memcpy(buffer, fw_p->data, fw_p->size);
 		memset(buffer + fw_p->size, 0xff, buffer_size - fw_p->size);
-		ti_do_download(dev, pipe, buffer, fw_p->size);
+		status = ti_do_download(dev, pipe, buffer, fw_p->size);
 		kfree(buffer);
 	}
 	release_firmware(fw_p);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/