linux-kernel - Re: [RFC] [PATCH -mm] cgroup: limit the amount of dirty file pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Sep 2008 18:39:12 +0200
From:	Andrea Righi <righi.andrea@...il.com>
To:	kamezawa.hiroyu@...fujitsu.com
CC:	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Paul Menage <menage@...gle.com>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	Carl Henrik Lunde <chlunde@...g.uio.no>,
	Divyesh Shah <dpshah@...gle.com>,
	Naveen Gupta <ngupta@...gle.com>,
	Fernando Luis V?zquez Cao <fernando@....ntt.co.jp>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hirokazu Takahashi <taka@...inux.co.jp>,
	Marco Innocenti <m.innocenti@...eca.it>,
	Satoshi UCHIDA <s-uchida@...jp.nec.com>,
	Ryo Tsuruta <ryov@...inux.co.jp>,
	Vivek Goyal <vgoyal@...hat.com>,
	Matt Heaton <matt@...ehost.com>,
	David Radford <dradford@...ehost.com>,
	containers@...ts.linux-foundation.org,
	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org
Subject: Re: [RFC] [PATCH -mm] cgroup: limit the amount of dirty file pages

kamezawa.hiroyu@...fujitsu.com wrote:
> ----- Original Message -----
>> This is a totally experimental patch against 2.6.27-rc5-mm1.
>>
>> It allows to control how much dirty file pages a cgroup can have at any
>> given time. This feature is supposed to be strictly connected to a
>> generic cgroup IO controller (see below).
>>
>> Interface: a new entry "filedirty" is added to the file memory.stat,
>> reporting the number of dirty file pages (in pages), and a new file
>> memory.file_dirty_limit_in_pages is added in the cgroup filesystem to
>> show/set the current limit.
>>
> Before staring patch review, why not dirty_ratio per memcg ?
> Is there difficult implementation issue ?

mmmh.. maybe it's a bit more complex (would add some overhead?) to
translate the limit from dirty_ratio into pages or bytes, because we
need to evaluate it in function of the per-cgroup dirtyable memory (lru
pages and free pages I suppose). Maybe it's enough to implement it
directly in determine_dirtyable_memory().

I can try to implement it and post a new patch.

-Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/