linux-kernel - Re: [PATCH v2 01/13] PCI Hotplug core: add 'name' param pci_hp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2008 11:18:37 -0600
From:	Alex Chiang <achiang@...com>
To:	Matthew Wilcox <matthew@....cx>
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	jbarnes@...tuousgeek.org, kristen.c.accardi@...el.com,
	kaneshige.kenji@...fujitsu.com
Subject: Re: [PATCH v2 01/13] PCI Hotplug core: add 'name' param
	pci_hp_register interface

* Matthew Wilcox <matthew@....cx>:
> On Tue, Sep 09, 2008 at 04:00:07AM -0600, Alex Chiang wrote:
> > -extern int pci_hp_register(struct hotplug_slot *, struct pci_bus *, int nr);
> > +extern int pci_hp_register(struct hotplug_slot *,
> > +			   struct pci_bus *,
> > +			   int nr,
> > +			   const char *name);
> 
> Not a huge fan of this style ... the usual style would be:
> 
> extern int pci_hp_register(struct hotplug_slot *, struct pci_bus *, int nr,
> 				const char *name);

Ok, will fix.

> Otherwise Acked-by: Matthew Wilcox <willy@...ux.intel.com>

Thanks.

/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/