linux-kernel - Re: [git pull] x86 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2008 20:43:33 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	x86 maintainers <x86@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] x86 fixes

On Tue, Sep 09, 2008 at 10:03:53AM -0700, H. Peter Anvin wrote:
> Adrian Bunk wrote:
>>
>> As far as I understood it it's a gas issue, and X86_GENERIC=y would  
>> therefore *not* fix the bug with gcc < 4.2 and affected binutils
>> since we pass -mtune=i686 for gcc < 4.2 with X86_GENERIC=y.
>>
>> Anything I miss?
>
> Well, for one thing, gcc doesn't actually pass the -mtune= option to  
> gas, it turns out.

What caused gas to emit the "wrong" NOPs?

> But yes, "-Wa,-march=generic32" is really the proper fix.

If I understand the binutils changelog correctly -march=generic32 
support was added one week before the NOP code in question, so all 
affected binutils versions support it.

> 	-hpa

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/