linux-kernel - Re: [git pull] x86 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Sep 2008 11:12:41 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Adrian Bunk <bunk@...nel.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	x86 maintainers <x86@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] x86 fixes

Adrian Bunk wrote:
>> Well, for one thing, gcc doesn't actually pass the -mtune= option to  
>> gas, it turns out.
> 
> What caused gas to emit the "wrong" NOPs?

It doesn't, after all, with the current gcc driver.  A future gcc driver 
may change that.  Of course, now when this has popped up on the radar 
screen, it might not happen.

>> But yes, "-Wa,-march=generic32" is really the proper fix.
> 
> If I understand the binutils changelog correctly -march=generic32 
> support was added one week before the NOP code in question, so all 
> affected binutils versions support it.

s/-march/-mtune/, but yes.  I suspect it was actually added *in order* 
to support the NOP code.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/