linux-kernel - Re: [patch] x86: some lock annotations for user copy paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080910121217.GA16013@elte.hu>
Date:	Wed, 10 Sep 2008 14:12:17 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Nick Piggin <npiggin@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [patch] x86: some lock annotations for user copy paths


* Ingo Molnar <mingo@...e.hu> wrote:

> > shouldn't some of that be conditional on pagefault_disable() 'n 
> > such?
> 
> i dont think so - those have their own special __atomic user-copy 
> primitives which Nick didnt touch.

hm, but the prefetch bits were touched, and -tip testing stumbled upon 
this false positive:

[   66.187448] PM: Adding info for No Bus:vcsa12
[   67.138685] evbug.c: Event. Dev: input0, Type: 20, Code: 0, Value: 500
[   80.149087] BUG: sleeping function called from invalid context at arch/x86/mm/fault.c:122
[   80.157344] in_atomic(): 1, irqs_disabled(): 0, pid: 6811, name: gam_server
[   80.164315] no locks held by gam_server/6811.
[   80.168685] Pid: 6811, comm: gam_server Not tainted 2.6.27-rc6-tip-00187-gbfd4ed7-dirty #2
[   80.177013] Call Trace:
[   80.179454]  [<ffffffff8026c1e8>] ? __debug_show_held_locks+0x22/0x24
[   80.185876]  [<ffffffff80242c4d>] __might_sleep+0x104/0x109
[   80.191430]  [<ffffffff8022fd25>] is_prefetch+0xe8/0x228
[   80.196760]  [<ffffffff8023050b>] do_page_fault+0x5d8/0x9a9
[   80.202361]  [<ffffffff802c8218>] ? sys_newstat+0x36/0x41
[   80.207774]  [<ffffffff80c3b2fa>] error_exit+0x0/0xb9

so i've excluded these commits for now. (once there's a fix i can 
continue testing it)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/