linux-kernel - Re: [PATCH 01/18] lirc core device driver infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080910122943.GA29441@infradead.org>
Date:	Wed, 10 Sep 2008 08:29:43 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Janne Grunau <j@...nau.net>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Jarod Wilson <jwilson@...hat.com>,
	linux-kernel@...r.kernel.org, Jarod Wilson <jarod@...hat.com>,
	Christoph Bartelmus <lirc@...telmus.de>,
	Mario Limonciello <superm1@...ntu.com>
Subject: Re: [PATCH 01/18] lirc core device driver infrastructure

On Wed, Sep 10, 2008 at 02:24:36PM +0200, Janne Grunau wrote:
> On Tuesday 09 September 2008 15:01:02 Christoph Hellwig wrote:
> 
> > > +	do {
> > > +		if (ir->open) {
> > > +			if (ir->jiffies_to_wait) {
> > > +				set_current_state(TASK_INTERRUPTIBLE);
> > > +				schedule_timeout(ir->jiffies_to_wait);
> > > +			} else {
> > > +				interruptible_sleep_on(
> > > +					ir->p.get_queue(ir->p.data));
> > > +			}
> >
> > No sleep on, please.  But this one should be trivial to fix anyway,
> > by just changing this to a
> >
> > 	set_current_state(TASK_INTERRUPTIBLE);
> > 	schedule();
> >
> > and using wake_up_process in the wakeup path.
> 
> No driver uses the get_queue callback. So I'm inclined to just remove 
> it. Christoph, any objections?

Sounds good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/