[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48C727B6.9000700@cs.columbia.edu>
Date: Tue, 09 Sep 2008 21:49:42 -0400
From: Oren Laadan <orenl@...columbia.edu>
To: Dave Hansen <dave@...ux.vnet.ibm.com>
CC: containers@...ts.linux-foundation.org, jeremy@...p.org,
linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [RFC v4][PATCH 9/9] File descriprtors (restore)
Dave Hansen wrote:
> On Tue, 2008-09-09 at 03:42 -0400, Oren Laadan wrote:
>> +static int cr_close_all_fds(struct files_struct *files)
>> +{
>> + int *fdtable;
>> + int n;
>> +
>> + do {
>> + n = cr_scan_fds(files, &fdtable);
>> + if (n < 0)
>> + return n;
>> + while (n--)
>> + sys_close(fdtable[n]);
>> + kfree(fdtable);
>> + } while (n != -1);
>> +
>> + return 0;
>> +}
>
> This needs to use an ERR_PTR(). It will save using the double-pointer.
I suppose you refer to the call to cr_scan_fds(): either 'fdtable'
or 'n' will have to pass-by-reference. Is it that you prefer it to be
fdtable = cr_scan_fds(files, &n);
?
Oren.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists