linux-kernel - Re: [PATCH 2/2] regulator: Add WM8400 regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1221076680.17091.259.camel@odin>
Date:	Wed, 10 Sep 2008 20:58:00 +0100
From:	Liam Girdwood <lrg@...nel.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Samuel Ortiz <sameo@...nedhand.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: Add WM8400 regulator support

On Wed, 2008-09-10 at 20:40 +0100, Mark Brown wrote:
> On Wed, Sep 10, 2008 at 07:39:28PM +0100, Liam Girdwood wrote:
> 
> > > +static unsigned int wm8400_dcdc_get_optimum_mode(struct regulator_dev *dev,
> > > +						 int input_uV, int output_uV,
> > > +						 int load_uA)
> > > +{
> > > +	return REGULATOR_MODE_IDLE;
> > > +}
> > > +
> 
> > This should return NORMAL by default. Probably best to add a lookup
> > table for IDLE & STANDBY if supported.
> 
> Yeah, I've changed it to NORMAL for now.  I'll add the lookup table in a
> followup patch later along with things like support for configuring the
> suspend modes of the device if that's OK?

OK by me.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/