[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200809102309.34159.bzolnier@gmail.com>
Date: Wed, 10 Sep 2008 23:09:33 +0200
From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To: Steven Noonan <steven@...inklabs.net>
Cc: linux-kernel@...r.kernel.org, mingo@...e.hu
Subject: Re: [PATCH] drivers/ide/ide-probe.c: uninitialized variable 'rc'
Hi,
On Tuesday 09 September 2008, Steven Noonan wrote:
> Fixed the warning by initializing 'rc' to zero.
>
> Signed-off-by: Steven Noonan <steven@...inklabs.net>
> ---
> drivers/ide/ide-probe.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
> index 994e410..e53c645 100644
> --- a/drivers/ide/ide-probe.c
> +++ b/drivers/ide/ide-probe.c
> @@ -1492,7 +1492,7 @@ static struct device_attribute *ide_port_attrs[] = {
>
> static int ide_sysfs_register_port(ide_hwif_t *hwif)
> {
> - int i, rc;
> + int i, rc = 0;
>
> for (i = 0; ide_port_attrs[i]; i++) {
> rc = device_create_file(hwif->portdev, ide_port_attrs[i]);
I recall seeing identical patch before:
http://article.gmane.org/gmane.linux.ide/33107
Does the existing code really results in gcc warning?
If so we may apply it just to shut-up the broken gcc version...
Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists