linux-kernel - Re: tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea8d860a0809110303g68d7cf2fs7affd9103abc9b24@mail.gmail.com>
Date:	Thu, 11 Sep 2008 12:03:52 +0200
From:	"Marcin Obara" <marcin_obara@...rs.sourceforge.net>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"Jiri Slaby" <jirislaby@...il.com>, tpm@...horst.net,
	kjhall@...ibm.com, linux-kernel@...r.kernel.org,
	srajiv@...ux.vnet.ibm.com, debora@...ux.vnet.ibm.com
Subject: Re: tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27

2008/9/11 Andrew Morton <akpm@...ux-foundation.org>:
> On Thu, 11 Sep 2008 00:11:37 +0200
> Jiri Slaby <jirislaby@...il.com> wrote:
>
>> Hi,
>>
>> is it possible to push
>> tpm-correct-tpm-timeouts-to-jiffies-conversion.patch
>> (the patch header follows) into 2.6.27, please?
>
> Sure.
>
>> From: Marcin Obara <marcin_obara@...rs.sourceforge.net>
>>
>> This patch fixes timeouts conversion to jiffies, by replacing
>> msecs_to_jiffies() calls with usecs_to_jiffies().  According to TCG TPM
>> Specification Version 1.2 Revision 103 (pages 166, 167) TPM timeouts and
>> durations are returned in microseconds (usec) not in miliseconds (msec).
>>
>> Signed-off-by: Marcin Obara <marcin_obara@...rs.sourceforge.net>
>> Cc: Marcel Selhorst <tpm@...horst.net>
>> Cc: Kylene Jo Hall <kjhall@...ibm.com>
>> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>
> Why?  I wasn't aware that this fixed anything which anyone had observed
> (pokes tongue out at the changelog).
>

This fixes i.e.: long hang while loading TPM driver, if TPM chip
starts in "Idle" state instead of "Ready" state.
Without this patch - 'modprobe' may hang for 30 seconds or more.
Please, push this patch into 2.6.27.

Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/