linux-kernel - Re: [PATCH] i2c-dev: Return correct error code on class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080911130442.6ebd10c6@hyperion.delvare>
Date:	Thu, 11 Sep 2008 13:04:42 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Sven Wegener <sven.wegener@...aler.net>
Cc:	i2c@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c-dev: Return correct error code on class_create() 
 failure

Hi Sven,

On Wed, 10 Sep 2008 21:30:27 +0200 (CEST), Sven Wegener wrote:
> We need to convert the error pointer from class_create(), else we'll return the
> successful return code from register_chrdev() on failure.
> 
> Signed-off-by: Sven Wegener <sven.wegener@...aler.net>
> ---
>  drivers/i2c/i2c-dev.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
> index af4491f..307d976 100644
> --- a/drivers/i2c/i2c-dev.c
> +++ b/drivers/i2c/i2c-dev.c
> @@ -583,8 +583,10 @@ static int __init i2c_dev_init(void)
>  		goto out;
>  
>  	i2c_dev_class = class_create(THIS_MODULE, "i2c-dev");
> -	if (IS_ERR(i2c_dev_class))
> +	if (IS_ERR(i2c_dev_class)) {
> +		res = PTR_ERR(i2c_dev_class);
>  		goto out_unreg_chrdev;
> +	}
>  
>  	res = i2c_add_driver(&i2cdev_driver);
>  	if (res)

Good catch. Patch applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/