linux-kernel - Re: [PATCH 2/5] drivers/media/common/tuners: Drop code after return or goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80b317760809110646l6e0f678v2d17d9823653d642@mail.gmail.com>
Date:	Thu, 11 Sep 2008 15:46:35 +0200
From:	"Richard Genoud" <richard.genoud@...il.com>
To:	"Julia Lawall" <julia@...u.dk>
Cc:	mchehab@...radead.org, v4l-dvb-maintainer@...uxtv.org,
	video4linux-list@...hat.com, vigneshbabu@...il.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/5] drivers/media/common/tuners: Drop code after return or goto

2008/9/11 Julia Lawall <julia@...u.dk>:
> From: Julia Lawall <julia@...u.dk>
>
> The break after the return or goto serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@...u.dk>
Reviewed-by: Richard Genoud <richard.genoud@...il.com>
> ---
>  drivers/media/common/tuners/mxl5007t.c     |    1 -
>  drivers/media/common/tuners/tda18271-fe.c  |    1 -
>  drivers/media/common/tuners/tda9887.c      |    1 -
>  drivers/media/common/tuners/tuner-simple.c |    1 -
>  4 files changed, 4 deletions(-)
>
> diff -u -p a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
> --- a/drivers/media/common/tuners/tuner-simple.c
> +++ b/drivers/media/common/tuners/tuner-simple.c
> @@ -1038,7 +1038,6 @@ struct dvb_frontend *simple_tuner_attach
>        case 0:
>                mutex_unlock(&tuner_simple_list_mutex);
>                return NULL;
> -               break;
>        case 1:
>                fe->tuner_priv = priv;
>
> diff -u -p a/drivers/media/common/tuners/tda18271-fe.c b/drivers/media/common/tuners/tda18271-fe.c
> --- a/drivers/media/common/tuners/tda18271-fe.c
> +++ b/drivers/media/common/tuners/tda18271-fe.c
> @@ -1155,7 +1155,6 @@ struct dvb_frontend *tda18271_attach(str
>        switch (instance) {
>        case 0:
>                goto fail;
> -               break;
>        case 1:
>                /* new tuner instance */
>                priv->gate = (cfg) ? cfg->gate : TDA18271_GATE_AUTO;
> diff -u -p a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c
> --- a/drivers/media/common/tuners/mxl5007t.c
> +++ b/drivers/media/common/tuners/mxl5007t.c
> @@ -979,7 +979,6 @@ struct dvb_frontend *mxl5007t_attach(str
>        switch (instance) {
>        case 0:
>                goto fail;
> -               break;
>        case 1:
>                /* new tuner instance */
>                state->config = cfg;
> diff -u -p a/drivers/media/common/tuners/tda9887.c b/drivers/media/common/tuners/tda9887.c
> --- a/drivers/media/common/tuners/tda9887.c
> +++ b/drivers/media/common/tuners/tda9887.c
> @@ -686,7 +686,6 @@ struct dvb_frontend *tda9887_attach(stru
>        case 0:
>                mutex_unlock(&tda9887_list_mutex);
>                return NULL;
> -               break;
>        case 1:
>                fe->analog_demod_priv = priv;
>                priv->mode = T_STANDBY;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/