| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200809110956.32777.sheng.yang@intel.com> Date: Thu, 11 Sep 2008 09:56:32 +0800 From: "Yang, Sheng" <sheng.yang@...el.com> To: Avi Kivity <avi@...ranet.com> Cc: Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] x86: Move VMX MSRs to msr-index.h On Wednesday 10 September 2008 22:30:15 Avi Kivity wrote: > Yang, Sheng wrote: > > On Tuesday 09 September 2008 21:47:03 Avi Kivity wrote: > >> Sheng Yang wrote: > >>> They are hardware specific MSRs, and we would use them in > >>> virtualization feature detection later. > >>> > >>> > >>> > >>> > >>> - > >>> -#define MSR_IA32_FEATURE_CONTROL 0x3a > >>> #define MSR_IA32_FEATURE_CONTROL_LOCKED 0x1 > >>> #define MSR_IA32_FEATURE_CONTROL_VMXON_ENABLED 0x > >> > >> Might as well move these two bitmask definitions. > > > > Um... I think it's better to leave them here, for the > > MSR_IA32_FEATURE_CONTROL is a MSR which can be put into msr-index.h, but > > the others are only bits of MSR... > > The EFER bits are in msr-index.h, and I think the msr index in one file > and the bits in another detract from clarity. I agree now, sorry for miss that... Would post another patch(es) to do this clean up... -- regards Yang, Sheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists