linux-kernel - Re: [PATCH 1/4] jbd: abort when failed to log metadata buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48C95867.5080707@redhat.com>
Date:	Thu, 11 Sep 2008 12:41:59 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
CC:	akpm@...ux-foundation.org, sct@...hat.com,
	linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org,
	jack@...e.cz, jbacik@...hat.com, cmm@...ibm.com, tytso@....edu,
	adilger@...sterfs.com, snitzer@...il.com, tglx@...utronix.de,
	yumiko.sugita.yf@...achi.com, satoshi.oshima.fk@...achi.com
Subject: Re: [PATCH 1/4] jbd: abort when failed to log metadata buffers

Hidehiro Kawai wrote:
> If we failed to write metadata buffers to the journal space and
> succeeded to write the commit record, stale data can be written
> back to the filesystem as metadata in the recovery phase.
> 
> To avoid this, when we failed to write out metadata buffers,
> abort the journal before writing the commit record.
> 
> Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
> Acked-by: Jan Kara <jack@...e.cz>
> ---
>  fs/jbd/commit.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> Index: linux-2.6.26-rc8-mm1/fs/jbd/commit.c
> ===================================================================
> --- linux-2.6.26-rc8-mm1.orig/fs/jbd/commit.c
> +++ linux-2.6.26-rc8-mm1/fs/jbd/commit.c
> @@ -762,6 +762,9 @@ wait_for_iobuf:
>  		/* AKPM: bforget here */
>  	}
>  
> +	if (err)
> +		journal_abort(journal, err);
> +
>  	jbd_debug(3, "JBD: commit phase 6\n");
>  
>  	if (journal_write_commit_record(journal, commit_transaction))

A little late for me to chime in, but why is this a journal_abort() when
journal aborts before and after this call __journal_abort_hard()?

I'm just not sure what's different about this one condition that we wish
to update the error and the superblock here?

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/