linux-kernel - Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080911185647.GA20188@elte.hu>
Date:	Thu, 11 Sep 2008 20:56:47 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Ingo Molnar wrote:
> > the false positive should be avoided, for example by unmapping the 
> > 'prev' mapping shortly before the leak check.
> >   
> 
> Yep.  I'll make it unmap just before setting acpi_gbl_permanent_mmap,
> which is when it switches to using plain old ioremap.
> 
> >> (All those other backtraces are just informational, right?)
> >>     
> >
> > no, they cause hard failures in my test setup. Nor do we want to litter 
> > the bootup log with messages that are not correct.
> >   
> 
> No, I mean that early_ioremap_debug causes all early_ioremap()s to 
> dump a stack trace, so most of the stack dumps in the boot log are 
> diagnostic/informational rather than indications of lots of problems.

ah - now i understand what you mean, sure. The only non-diagnostic 
message that the test barfed on was the leak warning itself. The others 
were there because i did a second boot with the diagnostic messages 
enabled as well. (so that there's a full track of what is mapped where)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/