linux-kernel - [PATCH 2/2] fix acpi ec set GPE storm flag bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b1360ffe431c427477d030eb5c182e87f1fcd85a.1221102420.git.kexin.hao@windriver.com>
Date:	Thu, 11 Sep 2008 11:17:45 +0800
From:	Kevin Hao <kexin.hao@...driver.com>
To:	ak@...ux.intel.com, astarikovskiy@...e.de,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: [PATCH 2/2] fix acpi ec set GPE storm flag bug

The intent of the code was clear, however the missing braces
meant that EC_FLAGS_GPE_STORM was incorrectly being set
all the time

Signed-off-by: Kevin Hao <kexin.hao@...driver.com>
---
 drivers/acpi/ec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 0c65e82..d8f273d 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -268,9 +268,10 @@ end:
 		/* it is safe to enable GPE outside of transaction */
 		acpi_enable_gpe(NULL, ec->gpe, ACPI_NOT_ISR);
 	} else if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags) &&
-		   atomic_read(&ec->irq_count) > ACPI_EC_STORM_THRESHOLD)
+		   atomic_read(&ec->irq_count) > ACPI_EC_STORM_THRESHOLD) {
 		pr_debug(PREFIX "GPE storm detected\n");
 		set_bit(EC_FLAGS_GPE_STORM, &ec->flags);
+	}
 	return 0;
 }
 
-- 
1.5.6.2.220.g44701

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/