linux-kernel - Re: [update3] [PATCH] init: bzip2 or lzma -compressed kernels and initrds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48C9A80D.1010703@zytor.com>
Date:	Thu, 11 Sep 2008 16:21:49 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Alain Knaff <alain@...ff.lu>
CC:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	w@....eu
Subject: Re: [update3] [PATCH] init: bzip2 or lzma -compressed kernels and
 initrds

Alain Knaff wrote:
>> There is no reason to include header files conditionally.
>>
>> It might be worthwhile to create a proper subdirectory rather than using
>> an underscored namespace (also, in general, dashes are preferred in
>> filenames.)
> 
> I hate to contradict you, but in that case, lots of other filenames
> would need fixing too:

Not arguing that.  However, in this case I think the right thing is to 
make a subdirectory.

>> Any reason to not just use <linux/compiler.h> here?
> 
> As you may have understood, the decompressors themselves are samples
> and/or reference implementations downloaded from elsewhere, and thus
> might not be up to the coding standards of the rest of the kernel.

I'm familiar with that.  However, I think in this case it is preferrable 
to use the all-kernel facilities, since there is an obvious direct mapping.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/