linux-kernel - Re: [PATCH 1/2] fix acpi ec read write bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1221108565.11106.12.camel@kevin>
Date:	Thu, 11 Sep 2008 12:49:25 +0800
From:	Kevin Hao <kexin.hao@...driver.com>
To:	Zhao Yakui <yakui.zhao@...el.com>
Cc:	ak@...ux.intel.com, astarikovskiy@...e.de,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 1/2] fix acpi ec read write bug

On Thu, 2008-09-11 at 12:07 +0800, Zhao Yakui wrote:
> On Thu, 2008-09-11 at 11:17 +0800, Kevin Hao wrote:
> > Fill in command unit of transaction_data structure, otherwise
> > gpe_transaction will skip read or write instruction.
> > 
> > Signed-off-by: Kevin Hao <kexin.hao@...driver.com>
> > ---
> >  drivers/acpi/ec.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> > index bd3555c..0c65e82 100644
> > --- a/drivers/acpi/ec.c
> > +++ b/drivers/acpi/ec.c
> > @@ -240,6 +240,7 @@ static int acpi_ec_transaction_unlocked(struct acpi_ec *ec, u8 command,
> >  	}
> >  	atomic_set(&ec->irq_count, 0);
> >  	/* fill in transaction structure */
> > +	ec->t.command = command;
> It is also OK to add this explicitly. In fact the ec->t.command will be
> assigned in the function of acpi_ec_write_cmd.

NO, I am using the latest linux-next kernel and I don't found
ec->t.command is assigned in acpi_ec_write_cmd function.

Thanks,
Kevin

> 
> Thanks.
> >  	ec->t.wdata = wdata;
> >  	ec->t.wlen = wdata_len;
> >  	ec->t.rdata = rdata;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/