linux-kernel - Re: [RFC/PATCH] dontdiff: generate from gitignore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0809121025460.3300@nehalem.linux-foundation.org>
Date:	Fri, 12 Sep 2008 10:36:49 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	Alexey Dobriyan <adobriyan@...il.com>,
	linux-kernel@...r.kernel.org, akpm <akpm@...ux-foundation.org>,
	samr <sam@...nborg.org>
Subject: Re: [RFC/PATCH] dontdiff: generate from gitignore

On Fri, 12 Sep 2008, Randy Dunlap wrote:
> 
> Generate the "dontdiff" file from the .gitignore files.

t's not quite as simple as that, though.

The .gitignore files are fundamentally location hierarchy-aware, so a 
ignore entry in one subdirectory only affects that subdirectory 
(recursively), so if you flatten then, you should take that into account.

As far as I can tell, your script will generate lots of incorrect entries 
due to this. Eg, it will generate

	parse.[ch]

as a dontdiff pattern, because scripts/genksyms/.gitignore has that, but 
that means that now it will ignore parse.c in all the _other_ places, 
where it *isn't* a generated file (ie mm/parse.c).

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/