linux-kernel - Re: [PATCH] [2/2] Don't complain about disabled irqs when the system has paniced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Sep 2008 21:50:54 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	torvalds@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [2/2] Don't complain about disabled irqs when the system has paniced

Hi!

> panic calls smp_send_stop which eventually calls smp_call_function_*.
> smp_call_function warns about disabled interrupts. But it's legal
> to call panic in this case. When this happens panic() prints
> several ugly backtraces. So don't check for disabled interrupts
> in panic state.
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
...

>  	/* Can deadlock when called with interrupts disabled */
> -	WARN_ON(irqs_disabled());
> +	WARN_ON(system_state < SYSTEM_PANIC && irqs_disabled());

Nice trap if someone adds state after panic... replace < with !=?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/