linux-kernel - Re: Partition check considered as error is breaking mounting in 2.6.27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Sep 2008 16:27:54 -0400
From:	"Bob Copeland" <me@...copeland.com>
To:	"Herton Ronaldo Krzesinski" <herton@...driva.com.br>
Cc:	"Alan Stern" <stern@...land.harvard.edu>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	bogdano@...driva.com.br,
	"Luiz Fernando N. Capitulino" <lcapitulino@...driva.com.br>,
	"Abdel Benamrouche" <draconux@...il.com>,
	"Damien Lallement" <dlallement@...driva.com>,
	"pterjan@...driva.com" <pterjan@...driva.com>,
	"Jens Axboe" <axboe@...nel.dk>
Subject: Re: Partition check considered as error is breaking mounting in 2.6.27

On Fri, Sep 12, 2008 at 4:14 PM, Herton Ronaldo Krzesinski
<herton@...driva.com.br> wrote:
> diff --git a/fs/partitions/check.c b/fs/partitions/check.c
> index 7d6b34e..15c70df 100644
> --- a/fs/partitions/check.c
> +++ b/fs/partitions/check.c
> @@ -499,9 +499,9 @@ int rescan_partitions(struct gendisk *disk, struct block_device *bdev)
>                if (!size)
>                        continue;
>                if (from + size > get_capacity(disk)) {
> -                       printk(KERN_ERR " %s: p%d exceeds device capacity\n",
> +                       printk(KERN_WARNING
> +                               " %s: p%d exceeds device capacity\n",
>                                disk->disk_name, p);
> -                       continue;

It might make sense to comment here that we intentionally want to add the
partition anyway.  That might keep someone from re-adding the continue (same
patch has already come up at least 3 times).

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/