[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20080911230244.d76a7310.akpm@linux-foundation.org>
Date: Thu, 11 Sep 2008 23:02:44 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Vegard Nossum" <vegard.nossum@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, tgraf@...g.ch,
penberg@...helsinki.fi, mingo@...e.hu, viro@...iv.linux.org.uk,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netlink: fix overrun in attribute iteration
On Fri, 12 Sep 2008 07:42:36 +0200 "Vegard Nossum" <vegard.nossum@...il.com> wrote:
> On Fri, Sep 12, 2008 at 1:52 AM, Andrew Morton
> <akpm@...ux-foundation.org> wrote:
> > On Thu, 11 Sep 2008 22:59:33 +0200
> > Vegard Nossum <vegard.nossum@...il.com> wrote:
> >
> >> #include <stdio.h>
> >>
> >> main(void)
> >> {
> >> printf("%d\n", -1 >= sizeof(int));
> >> }
> >>
> >
> > akpm:/home/akpm> gcc -W t.c
> > t.c: In function 'main':
> > t.c:5: warning: comparison between signed and unsigned
> >
> > Make of that what you will :)
>
> It doesn't show up with -Wall and the kernel isn't compiled with -W
> (aka. -Wextra) as far as I can see. Should it be turned on?
>
Last time I turned on -W, a full kernel build emitted nearly 10MB of
warnings.
Alas, some of them are useful, as we see here. They can be turned on
piecemeal - this one is -Wsign-compare, I think.
I think it would be good if owners of particular parts of the kernel
were to occasionally build their stuff with -W and spend half an hour
contemplating the result. Ditto `make C=1', to see what sparse thinks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists