linux-kernel - RE: [PATCH 5/5] drivers/dma/ioat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7F38996F7185A24AB9071ED4950AD8C101FEE5B9@swsmsx413.ger.corp.intel.com>
Date:	Fri, 12 Sep 2008 13:13:11 +0100
From:	"Sosnowski, Maciej" <maciej.sosnowski@...el.com>
To:	"Julia Lawall" <julia@...u.dk>
Cc:	<linux-kernel@...r.kernel.org>, <vigneshbabu@...il.com>,
	<richard.genoud@...il.com>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH 5/5] drivers/dma/ioat_dma.c: Drop code after return

Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> The break after the return serves no purpose.
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> ---
> 
>  drivers/dma/ioat_dma.c        |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
> index bc8c6e3..1ef68b3 100644
> --- a/drivers/dma/ioat_dma.c
> +++ b/drivers/dma/ioat_dma.c
> @@ -971,11 +971,9 @@ static struct ioat_desc_sw
>  	*ioat_dma_get_next_descriptor( switch
(ioat_chan->device->version) {
>  	case IOAT_VER_1_2:
>  		return ioat1_dma_get_next_descriptor(ioat_chan);
> -		break;
>  	case IOAT_VER_2_0:
>  	case IOAT_VER_3_0:
>  		return ioat2_dma_get_next_descriptor(ioat_chan);
> -		break;
>  	}
>  	return NULL;
>  }

You are right. Thanks for pointing this out.

Acked-by: Maciej Sosnowski <maciej.sosnowski@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/