linux-kernel - Re: OSS sound core optionalization has __init/_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h63p09iqi.wl%tiwai@suse.de>
Date:	Sat, 13 Sep 2008 17:19:01 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	"Mike Frysinger" <vapier.adi@...il.com>
Cc:	tj@...nel.org, "Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: OSS sound core optionalization has __init/__exit mismatches

At Fri, 12 Sep 2008 11:22:21 -0400,
Mike Frysinger wrote:
> 
> this commit:
> commit 1be95f401657e75984871c369d774d507e462939
> Author: Tejun Heo <tj@...nel.org>
> Date:   Thu Aug 28 16:42:51 2008 +0200
> sound: make OSS sound core optional
> 
> results in this failure:
> WARNING: vmlinux.o(.init.text+0xfbf0): Section mismatch in reference
> from the function _init_soundcore() to the function
> .exit.text:_cleanup_oss_soundcore()
> The function __init _init_soundcore() references
> a function __exit _cleanup_oss_soundcore().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __exit annotation of
> _cleanup_oss_soundcore() so it may be used outside an exit section.
> 
> and can easily be seen in sound/sound_core.c:
> ...
> static int __init init_soundcore(void)
> {
> ...
>                cleanup_oss_soundcore();
> ...
> }
> ...
> static void __exit cleanup_oss_soundcore(void)
> {
> ...
> }
> ...
> -mike

Thanks for reporting.  It was already fixed on my sound-2.6.git.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/