linux-kernel - Re: [PATCH] usbmon: fix tiny race exposed by the fastboot patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 13 Sep 2008 14:05:07 -0600
From:	Pete Zaitcev <zaitcev@...hat.com>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usbmon: fix tiny race exposed by the fastboot patches

On Sat, 13 Sep 2008 12:48:58 -0700, Arjan van de Ven <arjan@...radead.org> wrote:

> +++ b/drivers/usb/mon/mon_main.c
> @@ -361,12 +361,12 @@ static int __init mon_init(void)
>  	}
>  	// MOD_INC_USE_COUNT(which_module?);
>  
> -	usb_register_notify(&mon_nb);
>  
>  	mutex_lock(&usb_bus_list_lock);
>  	list_for_each_entry (ubus, &usb_bus_list, bus_list) {
>  		mon_bus_init(ubus);
>  	}
> +	usb_register_notify(&mon_nb);
>  	mutex_unlock(&usb_bus_list_lock);

Looks like the above does not add new deadlocks and does not
miss notifications, so ACK.

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/