linux-kernel - Re: [PATCH 1/2] pxafb: frame buffer overlay support for PXA27x.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080913102033.GB24437@flint.arm.linux.org.uk>
Date:	Sat, 13 Sep 2008 11:20:33 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Rodolfo Giometti <giometti@...eenne.com>,
	Eric Miao <eric.miao@...vell.com>,
	linux-kernel@...r.kernel.org, Rodolfo Giometti <giometti@...ux.it>,
	linux-fbdev-devel@...ts.sourceforge.net
Subject: Re: [PATCH 1/2] pxafb: frame buffer overlay support for PXA27x.

On Sat, Sep 13, 2008 at 03:05:40AM -0700, Andrew Morton wrote:
> > +static int overlay1fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
> > +{
> > +	struct overlayfb_info *fbi = (struct overlayfb_info *) info;
> > +	unsigned long off = vma->vm_pgoff << PAGE_SHIFT;
> >
> > +	if (off < info->fix.smem_len) {
> > +		vma->vm_pgoff += fbi->video_offset / PAGE_SIZE;
> > +		return dma_mmap_writecombine(o1_to_basefb(fbi)->dev, vma,
> > +					     fbi->map_cpu, fbi->map_dma,
> > +					     fbi->map_size);
> > +	}
> > +	return -EINVAL;
> > +}
> 
> No need to set VM_IO or VM_RESERVED, etc?

That's covered by dma_mmap_writecombine -> remap_pfn_range:

        vma->vm_flags |= VM_IO | VM_RESERVED | VM_PFNMAP;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/