linux-kernel - Re: [PATCH] Fix section for snd-aica platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h8wtuv1c5.wl%tiwai@suse.de>
Date:	Sun, 14 Sep 2008 23:56:10 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Uwe Kleine-König 
	<ukleinek@...ormatik.uni-freiburg.de>
Cc:	linux-kernel@...r.kernel.org,
	Adrian McMenamin <adrian@...en.demon.co.uk>,
	Paul Mundt <lethal@...ux-sh.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Fix section for snd-aica platform driver

At Sun, 14 Sep 2008 21:32:33 +0200,
Uwe Kleine-König wrote:
> 
> Don't use __init but __devinit to define probe function.  A pointer to
> snd_aica_probe is passed to the core via platform_driver_register and so the
> function must not disappear after the module is loaded.  Using __init
> and having HOTPLUG=y and SND_AICA=m the following probably oopses:
> 
> 	echo -n AICA > /sys/bus/platform/driver/AICA/unbind
> 	echo -n AICA > /sys/bus/platform/driver/AICA/bind
> 
> Strange enough add_aicamixer_controls which is only called by
> snd_aica_probe was already using __devinit.
> 
> While at it move the remove function to .devexit.text section.
> 
> Signed-off-by: Uwe Kleine-König <ukleinek@...ormatik.uni-freiburg.de>
> Cc: Adrian McMenamin <adrian@...en.demon.co.uk>
> Cc: Paul Mundt <lethal@...ux-sh.org>
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> 
> ---
>  sound/sh/aica.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Thanks, applied now.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/