linux-kernel - Re: proc: more debugging for "already registered" case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080913195424.2609fac2@infradead.org>
Date:	Sat, 13 Sep 2008 19:54:24 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: proc: more debugging for "already registered" case

On Sat, 13 Sep 2008 21:59:02 GMT
Linux Kernel Mailing List <linux-kernel@...r.kernel.org> wrote:

> Gitweb:
> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=665020c35e89a9e0643e21561e4f8f967f4f2c4b
> Commit:     665020c35e89a9e0643e21561e4f8f967f4f2c4b Parent:
> a551b98d5f6fce5897d497abd8bfb262efb33d2a Author:     Alexey Dobriyan
> <adobriyan@...il.com> AuthorDate: Sat Sep 13 02:33:06 2008 -0700
> Committer:  Linus Torvalds <torvalds@...ux-foundation.org>
> CommitDate: Sat Sep 13 14:41:50 2008 -0700

>  		if (strcmp(tmp->name, dp->name) == 0) {
> -			printk(KERN_WARNING "proc_dir_entry '%s'
> already "
> -					"registered\n", dp->name);
> +			printk(KERN_WARNING "proc_dir_entry '%s/%s'
> already registered\n",
> +				dir->name, dp->name);
>  			dump_stack();
>  			break;

Hi Linus, Alexey,

when doing this change, might as well turn it into a WARN() instead;
that way kerneloops.org can collect these, and in addition, it uses then
a more standard form of reporting (including filename/line number etc)

so how about this:

>From 7b907eb010b308c1a41871ea1b6ffb79d2538f01 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@...ux.intel.com>
Date: Sat, 13 Sep 2008 19:51:30 -0700
Subject: [PATCH] procfs: use WARN() rather than printk+backtrace

Use WARN() rather than a printk() + backtrace();
this gives a more standard format message as well as complete
information (including line numbers etc) that will be collected
by kerneloops.org

Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>
---
 fs/proc/generic.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 7821589..60a359b 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -547,9 +547,8 @@ static int proc_register(struct proc_dir_entry * dir, struct proc_dir_entry * dp
 
 	for (tmp = dir->subdir; tmp; tmp = tmp->next)
 		if (strcmp(tmp->name, dp->name) == 0) {
-			printk(KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
+			WARN(1, KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
 				dir->name, dp->name);
-			dump_stack();
 			break;
 		}
 
-- 
1.5.5.1



--
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/