linux-kernel - Re: 2.6.27-rc6-mmotm0913 build error - fs-sysfs-dirc-remove-unused-__sysfs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m17i9dgtsj.fsf@frodo.ebiederm.org>
Date:	Mon, 15 Sep 2008 11:15:08 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Valdis.Kletnieks@...edu
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org
Subject: Re: 2.6.27-rc6-mmotm0913 build error - fs-sysfs-dirc-remove-unused-__sysfs_get_dentry.patch

Valdis.Kletnieks@...edu writes:

> Trying to build 2.6.27-rc6-mmotm0913 dies a horrid death:
>
>   CC      fs/sysfs/dir.o
> fs/sysfs/dir.c: In function sysfs_mv_dir:
> fs/sysfs/dir.c:993: error: implicit declaration of function
> __sysfs_get_dentry
> fs/sysfs/dir.c:993: warning: assignment makes pointer from integer without a
> cast
> make[2]: *** [fs/sysfs/dir.o] Error 1
> make[1]: *** [fs/sysfs] Error 2
> make: *** [fs] Error 2
>
>
> Diagnosis: Andrew added fs-sysfs-dirc-remove-unused-__sysfs_get_dentry.patch,
> but somebody (Eric? was touching a lot of sysfs) in linux-next.patch added a
> new user in sysfs_mv_dir.

Thanks that is a very helpful diagnosis.

> Looks like people need to get on the same page about that patch?

Greg stopped halfway through merging my patchset earlier, so I'm
guessing that is why __sysfs_get_dentry looked unused.  

As seen above I really did use that function ;) So a patch
to remove it is the wrong thing.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/