lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2008 20:25:57 +0200 From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> To: Borislav Petkov <petkovbb@...glemail.com> Cc: linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org, Borislav Petkov <petkovbb@...il.com> Subject: Re: [PATCH 07/10] ide-atapi: prepare ide-cd expiry handler On Sunday 14 September 2008 13:35:55 Borislav Petkov wrote: > Push ide-cd expiry handler into the ide-cd header. Also, pass expiry > handler to ide_execute_command() in ide_issue_pc() for later. Uh, no. Please don't include "ide-cd.h" in ide-atapi.c. Instead just move the expiry handler to ide-atapi.c like it was done with ide_scsi_expiry(). It also seems that 'expiry' argument is not needed and expiry handler to use can be deduced from drive->media and drive->scsi. patches #8-10 look OK on the quick look but since they depend on earlier changes they also need to be updated. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists