linux-kernel - Re: wdt285: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080915080556.GB2654@infomag.infomag.iguana.be>
Date:	Mon, 15 Sep 2008 10:05:56 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: wdt285: fix sparse warnings

Ben,

...
> @@ -141,13 +141,13 @@ static long watchdog_ioctl(struct file *
>  	switch (cmd) {
>  	case WDIOC_GETSUPPORT:
>  		ret = 0;
> -		if (copy_to_user((void *)arg, &ident, sizeof(ident)))
> +		if (copy_to_user((void __user *)arg, &ident, sizeof(ident)))
>  			ret = -EFAULT;
>  		break;
>  
...

Isn't it better to fix this like we did with the other watchdog drivers:
        void __user *argp = (void __user *)arg;
        int __user *p = argp;
	...
		if (copy_to_user(argp, &ident, sizeof(ident)))
	...

Regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/