linux-kernel - Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200809162254.21514.nickpiggin@yahoo.com.au>
Date:	Tue, 16 Sep 2008 22:54:21 +1000
From:	Nick Piggin <nickpiggin@...oo.com.au>
To:	Michael Trimarchi <trimarchimichael@...oo.it>
Cc:	Hisashi Hifumi <hifumi.hisashi@....ntt.co.jp>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch

On Tuesday 16 September 2008 21:11, Michael Trimarchi wrote:
> Hi,
>
> > +        if (offset != file_pos_read(file))
> > +            file_pos_write(file, offset);
> >         retval = offset;
> >     }
>
> Is not more efficient here a compare xchg operation?

The compiler should do it if it was.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/