linux-kernel - Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <E1KfcXB-0003rP-6B@be1.7eggert.dyndns.org>
Date:	Tue, 16 Sep 2008 17:32:08 +0200
From:	Bodo Eggert <7eggert@....de>
To:	Hisashi Hifumi <hifumi.hisashi@....ntt.co.jp>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch

Hisashi Hifumi <hifumi.hisashi@....ntt.co.jp> wrote:

> Protecting file->f_pos with a lock adds some overhead but I think we should
> fix this.
> I used seqlock to serialize the access to file->f_pos. This approach is
> similar to inode->i_size synchronization.
> 
> Comments?

> +             if (offset != file_pos_read(file))
> +                     file_pos_write(file, offset);

Maybe file_pos_write should do this check?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/