linux-kernel - Re: [PATCH] gpio_free might sleep, blackfin architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Sep 2008 10:16:38 +0800
From:	"Bryan Wu" <cooloney@...nel.org>
To:	"Uwe Kleine-König" 
	<ukleinek@...ormatik.uni-freiburg.de>
Cc:	linux-kernel@...r.kernel.org,
	"David Brownell" <david-b@...bell.net>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	"Guennadi Liakhovetski" <g.liakhovetski@...gutronix.de>,
	"Greg KH" <greg@...ah.com>, "Kay Sievers" <kay.sievers@...y.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Russell King" <rmk+kernel@....linux.org.uk>
Subject: Re: [PATCH] gpio_free might sleep, blackfin architecture

On Tue, Sep 16, 2008 at 4:02 AM, Uwe Kleine-König
<ukleinek@...ormatik.uni-freiburg.de> wrote:
> According to the documentation gpio_free should only be called from task
> context only.  To make this more explicit add a might sleep to all
> implementations.
>
> This patch changes the gpio_free implementations for the blackfin
> architecture.
>

It looks fine for me, thanks a lot.

Acked-by: Bryan Wu <cooloney@...nel.org>


> Signed-off-by: Uwe Kleine-König <ukleinek@...ormatik.uni-freiburg.de>
> Cc: David Brownell <david-b@...bell.net>
> Cc: Bryan Wu <cooloney@...nel.org
> Cc: uclinux-dist-devel@...ckfin.uclinux.org
> Cc: Guennadi Liakhovetski <g.liakhovetski@...gutronix.de>
> Cc: Greg KH <greg@...ah.com>
> Cc: Kay Sievers <kay.sievers@...y.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Russell King <rmk+kernel@....linux.org.uk>
> ---
>  arch/blackfin/kernel/bfin_gpio.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/blackfin/kernel/bfin_gpio.c b/arch/blackfin/kernel/bfin_gpio.c
> index ecbd141..394006d 100644
> --- a/arch/blackfin/kernel/bfin_gpio.c
> +++ b/arch/blackfin/kernel/bfin_gpio.c
> @@ -1151,6 +1151,8 @@ void gpio_free(unsigned gpio)
>        if (check_gpio(gpio) < 0)
>                return;
>
> +       might_sleep();
> +
>        local_irq_save(flags);
>
>        if (unlikely(!(reserved_gpio_map[gpio_bank(gpio)] & gpio_bit(gpio)))) {
> --
> 1.5.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/