linux-kernel - Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <377425.67419.qm@web26204.mail.ukl.yahoo.com>
Date:	Tue, 16 Sep 2008 16:01:39 +0000 (GMT)
From:	Michael Trimarchi <trimarchimichael@...oo.it>
To:	7eggert@....de, Hisashi Hifumi <hifumi.hisashi@....ntt.co.jp>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch

hi,



----- Messaggio originale -----
> Da: Bodo Eggert <7eggert@....de>
> A: Hisashi Hifumi <hifumi.hisashi@....ntt.co.jp>; akpm@...ux-foundation.org; linux-kernel@...r.kernel.org; linux-fsdevel@...r.kernel.org
> Inviato: Martedì 16 settembre 2008, 17:32:08
> Oggetto: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
> 
> Hisashi Hifumi wrote:
> 
> > Protecting file->f_pos with a lock adds some overhead but I think we should
> > fix this.
> > I used seqlock to serialize the access to file->f_pos. This approach is
> > similar to inode->i_size synchronization.
> > 
> > Comments?
> 
> > +             if (offset != file_pos_read(file))
> > +                     file_pos_write(file, offset);
> 
> Maybe file_pos_write should do this check?
> 
I agree :)

Regards Michael

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


__________________________________________________
Do You Yahoo!?
Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi 
http://mail.yahoo.it 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/