linux-kernel - Re: [PATCH] vfs: added better file aio_read aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080916163603.GA13049@infradead.org>
Date:	Tue, 16 Sep 2008 12:36:03 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Marco Stornelli <marco.stornelli@...itel.it>
Cc:	viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfs: added better file aio_read aio_write operations
	presence check

On Tue, Sep 16, 2008 at 11:29:41AM +0200, Marco Stornelli wrote:
> From: Marco Stornelli <marco.stornelli@...il.com>
> 
> If a filesystem in the file operations specifies for read and write operations only do_sync_read and do_sync_write without 
> init aio_read and aio_write, there will be a kernel oops, because the vfs code check the presence of (to read for example)
> read OR aio_read method, then it calls read if it's pointer is not null. It's not sufficient because if the read function is 
> actually a do_sync_read, it calls aio_read but without checking the presence. I think a BUG_ON check can be more useful.

A NULL pointer derference is just as clear as the bug..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/