linux-kernel - Re: [PATCH] introduce boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Sep 2008 11:31:14 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
CC:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, jbaron <jbaron@...hat.com>
Subject: Re: [PATCH] introduce boot_printk()

Yinghai Lu wrote:
> On Tue, Sep 16, 2008 at 11:15 AM, H. Peter Anvin <hpa@...or.com> wrote:
>> Yinghai Lu wrote:
>>> you still can use
>>> pci_printk(v, KERN_PCI KERN_DEBUG "...\n");
>>>
>>> if vprintk is expanded to handle KERN_PCI and other tags...
>>> or even you could use
>>> pci_printk(v, KERN_ACPI KERN_DEBUG "...\n");
>>>
>> And the point of this, other than sheer verbosity?
> 
> let every file or componet of subsystem could control the print out
> via loglevel=pci_any_name:7
> 

pci_printk(v, KERN_ACPI KERN_DEBUG "...\n");
^^^^          ^^^^^^^^^

Not only do you have duplication, here, but inconsistency...

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/