linux-kernel - Re: [PATCH 1/1] avr32: added mem kernel command line option support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080916100622.36556a57@hskinnemo-gx745.norway.atmel.com>
Date:	Tue, 16 Sep 2008 10:06:22 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Marco Stornelli <marco.stornelli@...itel.it>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Linux AVR32 <kernel@...32linux.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] avr32: added mem kernel command line option support

Marco Stornelli <marco.stornelli@...itel.it> wrote:
> User-Agent: Thunderbird 2.0.0.16 (X11/20080720)

Please see Documentation/email-clients.txt. Thunderbird apparently has
pretty braindead defaults, but can be taught to behave.

> From: Marco Stornelli <marco.stornelli@...il.com>
> 
> Now is it ok? Sorry but it's the first time I submit a patch for the kernel.

Not really, sorry. This part is line-wrapped:

> --- linux-2.6.26.3/arch/avr32/kernel/setup.c.orig	2008-09-15
> 11:30:00.000000000 +0200
> +++ linux-2.6.26.3/arch/avr32/kernel/setup.c	2008-09-16
> 09:06:31.000000000 +0200

I've fixed it up, but I recommend that you send a few patches to
yourself and try to fix your setup. It's not much of a problem for a
small patch like this, but longer, more complicated ones may take quite
some time to unmangle.

The rest of the patch looks good. Although avr32 only supports 32-bit
physical addresses, I believe resource_size_t is more correct than
unsigned long.

Applied, thanks.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/