linux-kernel - Re: [PATCH 6/6] x86: add KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200809171408.42244.elendil@planet.nl>
Date:	Wed, 17 Sep 2008 14:08:41 +0200
From:	Frans Pop <elendil@...net.nl>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] x86: add KERN_APIC

Yinghai Lu wrote:
> On Wed, Sep 17, 2008 at 1:38 AM, Ingo Molnar <mingo@...e.hu> wrote:
>>> -             printk(KERN_WARNING "APIC calibration not consistent "
>>> +             printk(KERN_WARNING KERN_APIC "APIC calibration not
>>> consistent "
>>
>> here too the question arises: what should the semantics of the 'mixing'
>> of such subsystem printk tags with the classic priority tags be. I
>> think in this particular case we dont want the KERN_APIC tag, as that
>> would prevent this failure message to be printed by default. I.e. this
>> line should remain:
>>
>>> -             printk(KERN_WARNING "APIC calibration not consistent "
>>
>> to make sure this warning always shows up in the logs. Agreed?
>
> with
> DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 6); 
> the KERN_WARNING <5> will be showing up that warning, even without
> loglevl=apic:8
> 
> or change that  to
> DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 7);

Are you suggesting that each subsystem define its own default log level? 
That sounds truly horrible. It would mean that when reading code or 
adding new messages you'd always have to check what the default loglevel 
is for a particular subsystem.

I really like the idea of being able to easily increase the verbosity for 
a particular subsystem, but please make sure that by default all messages 
with the same level are treated the same, irrespective of which subsystem 
they belong to.

So IMO
       printk(KERN_WARNING "APIC calibration not consistent "
and
       printk(KERN_WARNING KERN_APIC "APIC calibration not consistent "
should do exactly the same thing if no 'loglevel=apic:X' is used and that 
should be guaranteed for all subsystems.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/