linux-kernel - Re: [PATCH 1/5] HID: move pantherlord FF processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Sep 2008 19:03:09 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jiri Slaby <jirislaby@...il.com>
cc:	linux-input@...r.kernel.org,
	Anssi Hannula <anssi.hannula@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] HID: move pantherlord FF processing

On Thu, 4 Sep 2008, Jiri Slaby wrote:

> Move the force feedback precessing into a separate module.
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>

> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 0784a09..a4d9695 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -373,6 +373,8 @@
>  #define USB_DEVICE_ID_QUAD_USB_JOYPAD	0x8800
>  #define USB_DEVICE_ID_DUAL_USB_JOYPAD	0x8866
>  
> +#define USB_VENDOR_ID_GREENASIA		0x0e8f
> +
>  #define USB_VENDOR_ID_WISEGROUP_LTD	0x6666
>  #define USB_VENDOR_ID_WISEGROUP_LTD2	0x6677
>  #define USB_DEVICE_ID_SMARTJOY_DUAL_PLUS 0x8802

Could we please preserve alphabetical ordering in hid-ids.h file?

Otherwise the series looks good to me, and Anssi didn't complain as well. 
Could you please rebase it on top of the current HID tree, fix the 
ordering, and send it to me again, I will apply it?

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/