[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m1r67i61rh.fsf@frodo.ebiederm.org>
Date: Wed, 17 Sep 2008 11:55:14 -0700
From: ebiederm@...ssion.com (Eric W. Biederman)
To: Cornelia Huck <cornelia.huck@...ibm.com>
Cc: Greg K-H <greg@...ah.com>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]sysfs: Don't emit a warning when sysfs_rename_link() fails.
Cornelia Huck <cornelia.huck@...ibm.com> writes:
> Hi Greg, hi Eric,
>
> the recent sysfs tagged directory changes switched device_rename() to
> sysfs_rename_link() - which is a good thing but AFAICS re-introduces
> the scary warnings when a netdevice is renamed to something that
> already exists (which I tried to fix with
> 36ce6dad6e3cb3f050ed41e0beac0070d2062b25).
A netdevice can not be renamed to something that already exists, correctly
and still emit warnings. Either it is a noop rename in which case
the fact that we delete the link before creating it will avoid warnings.
Or we are actually using a conflicting name. In which case it is a
real and valid problem. The netdev layer especially since the
networking layer already has validated that the rename is valid
before calling device_rename.
> The following patch switches sysfs_rename_link() to non-warning symlink
> creation again. It is on top of the current driver core series.
We don't need this. Using the non-warning symlink creation is unnecessary.
Using non-warning symlink creation hides real errors.
In practice any errors that show up will be errors in sysfs, because
the network subsystem validates everything before calling us.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists