lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Sep 2008 14:50:03 +0900 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> Cc: Daisuke Nishimura <nishimura@....nes.nec.co.jp>, linux-kernel@...r.kernel.org, linux-mm@...ck.org, akpm@...ux-foundation.org, balbir@...ux.vnet.ibm.com, xemul@...nvz.org Subject: Re: [PATCH -mm] memcg: fix handling of shmem migration On Wed, 17 Sep 2008 14:46:59 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote: > On Wed, 17 Sep 2008 13:31:49 +0900 > Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote: > > > PG_swapbacked flag of newpage should be set(if needed) before > > mem_cgroup_prepare_migration, because mem_cgroup_charge_common > > checks the flag and determines whether it sets PAGE_CGROUP_FLAG_FILE or not. > > > > Before this patch, if migrating shmem/tmpfs pages, newpage would be > > charged with PAGE_CGROUP_FLAG_FILE set, while oldpage has been charged > > without the flag. > > > Nice catch ! > Thank you. > > Hmm, should I add MEM_CGROUP_CHARGE_TYPE_SHMEM rather than > setting flag to newpage ? > > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> > I acked but.. can't this change moved into memcontrol.c ? Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists