linux-kernel - Re: [PATCH] x86: x86_{phys,virt}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <48D25E87.76E4.0078.0@novell.com>
Date:	Thu, 18 Sep 2008 12:58:31 +0100
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	<tglx@...utronix.de>, <linux-kernel@...r.kernel.org>,
	<hpa@...or.com>
Subject: Re: [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v3)

>>> Ingo Molnar <mingo@...e.hu> 18.09.08 13:20 >>>
>
>* Ingo Molnar <mingo@...e.hu> wrote:
>
>> * Jan Beulich <jbeulich@...ell.com> wrote:
>> 
>> > I'm really sorry for that, yet another merge oversight (not caught 
>> > because only re-tested on x86-64). Here's a better one.
>> 
>> ah, i see, the delta below. Nasty.
>
>the attached config fails in a similar way.

Hmm, yes, other than in .27, -tip derives resource_size_t from phys_addr_t,
regardless of CONFIG_RESOURCES_64BIT (and the config you provided
is a non-PAE one). I have to question that change, which I'm sure is
responsible for this failure. If there's a good reason for this, then
phys_addr_valid() should use phys_addr_t as its parameter type (and
so should ioremap() & Co), and the pre-processor conditional should
then change to depend on CONFIG_PHYS_ADDR_T_64BIT. Since ioremap()
would need to change first, I'd have to withdraw the patch until that
gets sorted out.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/