linux-kernel - PCI: Fix MSI-HOWTO.txt info about MSI-X MMIO space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87vdwtv1m2.fsf@shaolin.home.digitalvampire.org>
Date:	Thu, 18 Sep 2008 09:51:33 -0700
From:	Roland Dreier <roland@...italvampire.org>
To:	jbarnes@...tuousgeek.org
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: PCI: Fix MSI-HOWTO.txt info about MSI-X MMIO space

The current MSI-HOWTO.txt says that device drivers should not request
the memory space that contains MSI-X tables.  This is because the
original MSI-X implementation did a request_mem_region() on this
space, but that code was removed long ago (in the pre-git era, in
fact).  Years after the code was changed, we might as well clean up
the documention to avoid a confusing mention of requesting regions:
drivers using MSI-X can just use pci_request_regions() just like any
other driver, and so there's no need for MSI-HOWTO.txt to talk about
this at all.

Signed-off-by: Roland Dreier <roland@...italvampire.org>
---
 Documentation/MSI-HOWTO.txt |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/Documentation/MSI-HOWTO.txt b/Documentation/MSI-HOWTO.txt
index a51f693..256defd 100644
--- a/Documentation/MSI-HOWTO.txt
+++ b/Documentation/MSI-HOWTO.txt
@@ -236,10 +236,8 @@ software system can set different pages for controlling accesses to the
 MSI-X structure. The implementation of MSI support requires the PCI
 subsystem, not a device driver, to maintain full control of the MSI-X
 table/MSI-X PBA (Pending Bit Array) and MMIO address space of the MSI-X
-table/MSI-X PBA.  A device driver is prohibited from requesting the MMIO
-address space of the MSI-X table/MSI-X PBA. Otherwise, the PCI subsystem
-will fail enabling MSI-X on its hardware device when it calls the function
-pci_enable_msix().
+table/MSI-X PBA.  A device driver should not access the MMIO address
+space of the MSI-X table/MSI-X PBA.
 
 5.3.2 API pci_enable_msix
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/