linux-kernel - Re: [PATCH 1/5 #2] HID: move pantherlord FF processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0809181925050.4671@pegasus.suse.cz>
Date:	Thu, 18 Sep 2008 19:29:10 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jiri Slaby <jirislaby@...il.com>
cc:	linux-input@...r.kernel.org, anssi.hannula@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5 #2] HID: move pantherlord FF processing

On Thu, 18 Sep 2008, Jiri Slaby wrote:

> +config HID_PANTHERLORD
> +	tristate "Pantherlord"
> +	default m
> +	depends on USB_HID
> +	---help---
> +	Support for PantherLord/GreenAsia based device support (including
> +	force feedback).

This comment is a little bit misleading -- it says that 
CONFIG_HID_PANTHERLORD includes force feedback support, but you have to 
turn that on explicitly by:

> +config PANTHERLORD_FF
> +	bool "Force feedback support"

Also, mentioning "Pantherlord" here might make things more clear, this way 
it looks like this enables generic force feedback.

I will fix that up in the patchset, if you don't mind, and apply.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/